Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update frontend image #513

Merged
merged 4 commits into from
Apr 2, 2024
Merged

Conversation

blackzlq
Copy link
Collaborator

@blackzlq blackzlq commented Apr 1, 2024

  1. Remove enabled filter for two filters.
  2. Add more description on the filters

Tested-by: zlq

1. Remove enabled filter for two filters.
2. Add more description on the filters

Tested-by: zlq
@blackzlq blackzlq requested a review from imreddy13 April 1, 2024 06:02
@blackzlq
Copy link
Collaborator Author

blackzlq commented Apr 1, 2024

/gcbrun

Change to higher

Tested-by: zlq
@blackzlq
Copy link
Collaborator Author

blackzlq commented Apr 1, 2024

/gcbrun

wrong place

Tested-by: zlq
@blackzlq
Copy link
Collaborator Author

blackzlq commented Apr 1, 2024

/gcbrun

@blackzlq blackzlq requested a review from bjornsen April 1, 2024 18:03
@blackzlq
Copy link
Collaborator Author

blackzlq commented Apr 1, 2024

/gcbrun

Copy link
Collaborator

@imreddy13 imreddy13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

applications/rag/frontend/container/templates/index.html Outdated Show resolved Hide resolved
deleted colon

Tested-by: zlq
@blackzlq
Copy link
Collaborator Author

blackzlq commented Apr 1, 2024

/gcbrun

@blackzlq blackzlq enabled auto-merge (squash) April 1, 2024 21:57
@blackzlq
Copy link
Collaborator Author

blackzlq commented Apr 1, 2024

/gcbrun

@blackzlq
Copy link
Collaborator Author

blackzlq commented Apr 1, 2024

There is no way for this change affect existing test, we haven't update the image SHA, rerun the test

@blackzlq
Copy link
Collaborator Author

blackzlq commented Apr 1, 2024

/gcbrun

@blackzlq blackzlq merged commit 3c940aa into GoogleCloudPlatform:main Apr 2, 2024
3 of 4 checks passed
ryanaoleary pushed a commit that referenced this pull request Apr 3, 2024
* Update frontend image

1. Remove enabled filter for two filters.
2. Add more description on the filters

Tested-by: zlq

* Update frontend image

Change to higher

Tested-by: zlq

* Update frontend image

wrong place

Tested-by: zlq

* Update frontend image

deleted colon

Tested-by: zlq
kfswain pushed a commit that referenced this pull request Apr 15, 2024
* Update frontend image

1. Remove enabled filter for two filters.
2. Add more description on the filters

Tested-by: zlq

* Update frontend image

Change to higher

Tested-by: zlq

* Update frontend image

wrong place

Tested-by: zlq

* Update frontend image

deleted colon

Tested-by: zlq
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants